[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16842 [Tor Browser]: Media tab missing from Page Info

#16842: Media tab missing from Page Info
-------------------------+-------------------------------------------------
     Reporter:  mcs      |      Owner:  tbb-team
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  ff38-esr,tbb-5.0-regression,
   Resolution:           |  TorBrowserTeam201508R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:4 gk]:
 > Okay, a couple of thoughts:
 > 1) Can't we just do something like
 > {{{
 > if (Services.prefs.getBoolPref("security.nocertdb")) {
 >   this.initializationPromise = Promise.resolve();
 >   this._storage = null;
 > } else {
 >   this.initializationPromise = this._storage.initialize();
 > }
 > }}}
 > (plus the comments)? There seems no point in trying to run the whole
 init goop in `this._storage.initialize()` if we are checking the nocertdb
 pref later anyway and assigning values to `this.initializationPromise`
 depending on it. Or maybe a better explanation: Just checking the pref
 (which we do anyway) to get to know whether the initialization fails due
 to it or not is enough; there is no need to try to run the init code, too.

 This is a very good idea.

 > 2) You cleaned up some indentations, could you do that with the other
 > {{{
 > if (!this._storage)
 >     throw "No storage to set login saving enabled";
 > }}}
 > blocks as well?

 Yes, we will fix them.

 > 3) I get
 >
 > {{{
 > NS_ERROR_FAILURE: Component returned failure code: 0x80004005
 (NS_ERROR_FAILURE) [nsIPK11Token.initPassword] crypto-SDR.js:85:0
 > }}}
 > at start-up and vaguely remember that the crypto initialization was
 broken due to `security.nocertdb` as well but got fixed somehow. I can't
 seem to find the ticket anymore, though. Is this a different issue?

 That is caused by this same issue... not calling _storage.initialize()
 should make this go away.

 Thanks for your review and suggestions. We will post a new patch very
 soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16842#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs