[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #15493 [Tor Browser]: Redirects sometimes seem to break circuit status UI
#15493: Redirects sometimes seem to break circuit status UI
-----------------------------+------------------------------------------
Reporter: mikeperry | Owner: gk
Type: defect | Status: needs_revision
Priority: normal | Milestone:
Component: Tor Browser | Version:
Resolution: | Keywords: tbb-circuit-display, tbb-5.0
Actual Points: | Parent ID:
Points: |
-----------------------------+------------------------------------------
Changes (by arthuredelstein):
* status: needs_review => needs_revision
Comment:
Replying to [comment:9 gk]:
> Thinking a bit about it what speaks against updating the circuit
info/making the decision whether to show the circuit or not only when the
user is clicking on the green onion and opening the Torbutton menu? There
seems to be no need to make that call already once a tab gets selected for
instance. Putting that into the onpopupshowing handler or something
similar should cope with the possible race conditions and avoid any code
execution wrt the display until a user really wants to see it. Not sure if
there would be some lag while updating the display but looking at the
involved operations a doubt that.
That's a good suggestion. I think we would also like the display to update
if new circuit info arrives while the menu is being held open by the user,
however. I'll look into how this might be done cleanly. (Probably the
patch in my previous comment can be postponed while we think about this.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15493#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs