[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19163 [Core Tor/Tor]: Make sure clients almost always use ntor
#19163: Make sure clients almost always use ntor
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
Priority: Medium | needs_revision
Component: Core Tor/Tor | Milestone: Tor:
Severity: Normal | 0.2.9.x-final
Keywords: rsos, tor-hs, TorCoreTeam201607, | Version:
review-group-6 | Resolution:
Parent ID: | Actual Points: 5
Reviewer: nickm | Points: 1.0
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_review => needs_revision
* reviewer: => nickm
Comment:
Actual-review-points: .1
Added some comments on the gitlab page. Issues seem minor. I'm most
concerned here about the testing of this, but if you've tested that it
doesn't break hidden services, I believe it.
(Have you looked at the test coverage for the lines that changed?)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19163#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs