Re: [tor-bugs] #19755 [Metrics/CollecTor]: improve code quality of bridgedescs module

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19755: improve code quality of bridgedescs module
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Replying to [comment:13 iwakeh]:
 > I looked closer at the "recent" path commit, b/c I also provide a
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19720
 -reread-configuration&id=57d1d184c7f44f1cf01e892bb1e070cdd92f7ea9 commit]
 for that in the branch for #19720.
 > We arrived at different solutions:
 > You only log the ConfigurationException and I let it escalate.
 > My reasoning is that, if a Path cannot be constructed it means there is
 an invalid entry in collector.properties.  Thus, the module run should
 fail (this will be logged).

 Ah, makes sense, happy to use your patch and discard mine.

 > Maybe, a third solution that sets a recent path as attribute will be
 better?

 What would be the goal there?  I agree that the module shouldn't run if
 the configuration is invalid.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19755#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs