[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19875 [Core Tor/Tor]: shuffle our bridges when we load them from config

#19875: shuffle our bridges when we load them from config
--------------------------+------------------------------
 Reporter:  arma          |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------

Comment (by hdevalence):

 Hi, a first patch is here:
 https://code.ciph.re/hdevalence/tor/commit/4fda92e51bc5c69f5ba4c19c22184a1e0b87d9c1

 I'm not really sure what the right way to write a test for it is -- the
 description of the intended behaviour above relies on a bunch of other
 parts of tor behaving in a certain way (e.g., interaction with the
 statefile).  Testing just that `shuffle_bridge_list()` actually shuffles
 the list doesn't ensure the behaviour in the top of the ticket -- is that
 OK?

 Also, should this behaviour be configurable, instead of always-on?  Do
 people rely on bridge ordering?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19875#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs