[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19872 [Core Tor/Tor]: Introduce prefixed sign/verify functions
#19872: Introduce prefixed sign/verify functions
-------------------------------------------------+-------------------------
Reporter: asn | Owner:
Type: task | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.2.???
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 029-proposed, tor-hs, | Actual Points: 0.3
TorCoreTeam201608 |
Parent ID: | Points: 0.3
Reviewer: | Sponsor:
| SponsorR-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
Comment:
Two small things:
* Need documentation on the returned value that is 0 on success and -1 on
error. Either that or we document the return value of `ed25519_sign()`
which has none documented in `crypto_ed25519.c`.
* There is lots of `strlen(prefix_str)`, could be nicer to do it once and
then use it. Also, is there a chance that we would like to use this for a
non string prefix? Would it be bad to just go with `uint8_t *` and pass
the prefix len as param as well even though it's a string?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19872#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs