[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13953 [Core Tor/Tor]: Self-test reachability test - Listen address from ORPort is ignored, it uses default address unless specified via Address argument

#13953: Self-test reachability test - Listen address from ORPort is ignored, it
uses default address unless specified via Address argument
-----------------------------------------------+---------------------------
 Reporter:  s7r                                |          Owner:  teor
     Type:  enhancement                        |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.2.5.10
 Severity:  Normal                             |     Resolution:
 Keywords:  review-group-7, TorCoreTeam201608  |  Actual Points:  1.0
Parent ID:  #17782                             |         Points:  3
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by teor):

 * status:  merge_ready => needs_review
 * actualpoints:  0.5 => 1.0


Comment:

 Please see my branch bug13953 on https://github.com/teor2345/tor.git

 I've removed the duplicate code via refactoring, which means the string is
 only used once.

 I also reworded the log message to make it clearer that:
 * if the relay has a static IPv4 address, use 'Address' (the IPv4 address
 in the descriptor)
 * if the relay is behind NAT, use 'ORPort <Port> NoListen' for the
 external port (the IP address on a NoListen port is ignored, only the port
 is put in the descriptor), and 'ORPort <Port> NoAdvertise' for the
 internal port (binding to all addresses is the most functional default, as
 NAT often implies DHCP).

 This covers the most common causes of this issue: multiple static public
 IPv4, static IPv4 with NAT, and dynamic IPv4 with NAT.

 I didn't write a unit test - if we want to unit test
 router_build_fresh_descriptor, we should do that in a separate ticket.

 s7r, if you're happy with this, please put it into merge_ready for nickm
 to look at.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13953#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs