[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #15852 [Applications/Tor Browser]: Remove/synchronize Torbutton SOCKS pref logic
#15852: Remove/synchronize Torbutton SOCKS pref logic
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner: brade
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-4.5-regression, tbb-torbutton- | Actual Points:
conversion, TorBrowserTeam201608R |
Parent ID: | Points:
Reviewer: | Sponsor:
| SponsorU
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
commit 573bb7fb3b22cfc28d3dce01e2378d1b181e6d43 looks good.
re commit 6244aadf7cfd944e8b53aabd1da52fe40df89f96:
1) It seems we don't need to add/remove an observer for `network.proxy`
anymore in torbutton,js?
2) Maybe add `3. Reset Security Slider settings" in
`torbutton_prefs_reset_defaults()`?
3) I have the feeling that
{{{
// XXX: Hack for TBB people who alternate between transproxy and non
}}}
in `startup-observer.js` can go as well or did I miss something?
commit ab40a9b20bab2d2608ad528830338c24fcf98e32 looks good.
commit aa5cceae245efca766d5287d6754fac9c589b89e looks good.
So, just the nits above + squashing the commits into a single one and we
are good here, thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15852#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs