[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19791 [Metrics/metrics-lib]: Use CollecTor's index.json for download; adapt current download to use new date format
#19791: Use CollecTor's index.json for download; adapt current download to use new
date format
---------------------------------+-----------------------------------
Reporter: karsten | Owner: iwakeh
Type: defect | Status: needs_review
Priority: High | Milestone: metrics-lib 1.4.0
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Changes (by iwakeh):
* status: assigned => needs_review
Comment:
Please review [https://gitweb.torproject.org/user/iwakeh/metrics-
lib.git/?h=task-19791-use-index.json this branch] (the four commits on top
of slf4j).
There are also many tests now and coverage is reasonably high everywhere
regarding new classes.
Please review carefully as I couldn't base the implementation on existing
tests.
Setting
`-Ddescriptor.collector=org.torproject.descriptor.index.DescriptorIndexCollector`
will use the new descriptor collector method. Without the property
setting the old method is used.
The json implementation is encapsulated in IndexNode. One test reads and
writes a current index.json from the main CollecTor instance (see
test.json in test/resources). The various compression methods are
contained in FileType, where it is easy to add more in future, if
necessary.
This json writing/reading will be used in the next CollecTor, too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19791#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs