[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #19968 [Core Tor/Tor]: Test fails on Debian experimental reproducible builds
#19968: Test fails on Debian experimental reproducible builds
------------------------------+--------------------------------
Reporter: cypherpunks | Owner:
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version: Tor: 0.2.9.1-alpha
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------+--------------------------------
A [https://tests.reproducible-
builds.org/debian/rbuild/experimental/i386/tor_0.2.9.1-alpha-1.rbuild.log
recent build] on the reproducible build machines with Debian experimental
fails on one test.
{{{
util/num_cpus:
FAIL ../src/test/test_util.c:3689: assert(num OP_LE 16): 18 vs 16
[num_cpus FAILED]
}}}
This test was added in
[https://gitweb.torproject.org/tor.git/commit/?id=603cb712ef756dd700a52e837bcd643a96311ad6
commit 603cb712ef756dd700a52e837bcd643a96311ad6] which expects the maximum
number of CPUs to be 16. The
[https://gitweb.torproject.org/tor.git/tree/src/common/compat.c?id=8feb301413cc0f23b37dedbac0c57de25b88f519#n2801
compute_num_cpus function] only logs a message for machines with more than
16 CPUs but doesn't clamp the return value to 16. So there is a
discrepancy between the implementation and the test. (Why is there a limit
anyway?)
Furthermore, the preprocessor macro that defines the maximum number of
CPUs isn't public and can't be used in tests leading to undefined magic
numbers.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19968>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs