[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17238 [Core Tor/Tor]: prop224: Implement HSDir support
#17238: prop224: Implement HSDir support
-------------------------------------------------+-------------------------
Reporter: dgoulet | Owner: dgoulet
Type: enhancement | Status:
| needs_revision
Priority: High | Milestone: Tor:
| 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, prop224, TorCoreTeam201608, | Actual Points:
review-group-7, actualreviewpoints=2 |
Parent ID: #12424 | Points: parent
Reviewer: asn | Sponsor:
| SponsorR-must
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_information => needs_revision
Comment:
Replying to [comment:17 dgoulet]:
> I've merged all your things! _minor_ fixes here and there mostly to
follow some syntax but that's it. I've integrated them in the current
commit that exists. The `fetch` feature has its own commit as well as the
unit test for it. Finally, the "make check-spaces happy" is also its own
commit.
>
> On top of all this, I've added a commit for the consensus params
(discussed in #19899). This is imo ready for a `merge_ready` state that is
put it in nickm's court.
>
Hmm, you mean `af4d413`?
I don't see a consensus param there. I only see a torrc option being
introduced.
I don't think a torrc option is that useful: I'd actually like a real
consensus param (like `SRVAgreements`). Am I reading this right?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17238#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs