Re: [tor-bugs] #14272 [Applications/Tor Launcher]: Make Tor Launcher work with Unix Domain Socket option

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#14272: Make Tor Launcher work with Unix Domain Socket option
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  brade
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Launcher            |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-security, TorBrowserTeam201608R  |  Actual Points:
Parent ID:  #14270                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by gk):

 Two things (no need to create a new branch if 2. is moot):

 1. In the commit description s/is is use/is in use/

 2. Why do we have a new param for getTorFile()? Do we expect more calls
 with `aMustExist === false`? If not, why not just omit that param (and do
 something like `"control_socket" == aTorFileType` again) or at least
 rename it to something more descriptive than `aMustExist` (like
 `aControlSocket`)?

 I was confused about the `!aMustExist` check as the connection between
 that and doing `f.normalize();` seems not obvious at first glance.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14272#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs