[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23106 [Core Tor/Tor]: Audit code for swapped ntoh*/hton* calls
#23106: Audit code for swapped ntoh*/hton* calls
--------------------------+------------------------------------
Reporter: nickm | Owner:
Type: defect | Status: new
Priority: Low | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by nickm):
I think that the hs crew already spotted this one:
{{{
src/or/hs_descriptor.c: set_uint64(dst + offset,
tor_ntohll(desc->plaintext_data.revision_counter));
}}}
And that seems to be all. (Methodology: I grepped for `get/set_uint[^8]`,
and read all of the lines that didn't have the appropriate hton/ntoh
incant.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23106#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs