[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23240 [Applications/Tor Launcher]: do not show progress bar at zero when bootstrap progress is greater than zero
#23240: do not show progress bar at zero when bootstrap progress is greater than
zero
---------------------------------------+------------------------------
Reporter: mcs | Owner: brade
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Launcher | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201708R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor: Sponsor4
---------------------------------------+------------------------------
Comment (by mcs):
Replying to [comment:2 dcf]:
> comment:1 looks like an effective workaround, but I suspect it can be
addressed in a more direct way. I think the root of the problem is that
progressMeter.value is reset to 0 every time the progress bar dialog is
shown. I added some logging:
> ...
> Notice that when initDialog is called the second time, meter.value is
reset to 0, rather than remembering its previous value of 90. Maybe this
is because [https://gitweb.torproject.org/tor-
launcher.git/tree/src/chrome/content/network-settings.js?h=0.2.12.3#n1252
openProgressDialog] creates a brand new dialog from scratch? Perhaps
instead, it could keep the same dialog in memory, and show or hide it as
appropriate, so that meter.value retains its state.
Thanks for looking at this problem. Kathy and I considered but decided
against caching the current value. We think it is more elegant — and
safer — for Tor Launcher to be stateless with respect to the progress
value. For example, even if tor needs to reset its notion of progress due
to a restart or because of radical reconfiguration, the Tor Launcher
progress bar will never show an incorrect value.
> I ''don't'' think the usability problem from #22266 is an initial jump
from 0% to 80%. That's normal and expected with an up-to-date consensus
cache.
Agreed, although I think it is better to hide that jump (progress isn't
really zero so why show it as zero?)
Other opinions?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23240#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs