[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22802 [Core Tor/Tor]: Avoid use of "0" with tor_parse_foo()

#22802: Avoid use of "0" with tor_parse_foo()
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  closed
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:  fixed
 Keywords:  review-group-22  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 I've removed the ????, squashed, and merged.

 I'm not sure about the base>0 check; it's not _always_ wrong -- it's just
 wrong for inputs that we expect to be in decimal.  I'm planning to leave
 it as-is.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22802#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs