[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14201 [Metrics/Onionoo]: Configure out/ directory path somewhere else than in web.xml.

#14201: Configure out/ directory path somewhere else than in web.xml.
-----------------------------+--------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Onionoo-1.4.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Hmm, there's one major issue with this approach: This change is backward-
 incompatible with respect to the hourly updater, which previously used
 `"."` as base directory rather than
 `"/srv/onionoo.torproject.org/onionoo"`.

 And another, minor issue is that we're now defining that path in multiple
 places. This seems bad for future maintenance, in particular if we ever
 want to rename Onionoo and update that path.

 How about we limit this change to just the server part and leave the
 hourly updater unchanged. That would implement this ticket. I could edit
 the patch, unless you'd rather want to do that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14201#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs