[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23360 [Core Tor/Tor]: prop224: Service has dead code which removed a feature

#23360: prop224: Service has dead code which removed a feature
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  dgoulet
     Type:  defect           |         Status:  needs_revision
 Priority:  High             |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  asn              |        Sponsor:
-----------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hmm. Patch looks good to me, but not sure why you swapped the content of
 `hs_hsdir_set_changed_consider_reupload()` with
 `hs_service_dir_info_changed()`. I don't mind the func name change that
 much, but now the comment has been outdated. The `consider_reupload()`
 func has better comment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23360#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs