[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #23366 [Core Tor/Tor]: test: test_options_validate__outbound_addresses is broken
#23366: test: test_options_validate__outbound_addresses is broken
------------------------------+--------------------------------
Reporter: dgoulet | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Keywords: tor-test
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------+--------------------------------
Turns out that `test_options_validate__outbound_addresses()` tries to test
a bad `OutboundBindAddress` option and thus expects `options_validate()`
to return -1.
However, in `options_validate()`:
{{{
if (parse_outbound_addresses(options, 1, msg) < 0)
return -1;
}}}
... but if you look at `parse_outbound_addresses()` it ONLY returns 0 so
it's simply not working. Was added in with commit `81c78ec7556` which is
tor-0.3.0.3-alpha.
`options_act()` also calls `parse_outbound_addresses()` in the same way.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23366>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs