[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26817 [Core Tor/Tor]: Use NSS for DH
#26817: Use NSS for DH
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 035-roadmap-subticket, 035-triaged- | Actual Points:
in-20180711 |
Parent ID: #26631 | Points:
Reviewer: catalyst | Sponsor:
| Sponsor8-can
-------------------------------------------------+-------------------------
Comment (by catalyst):
Replying to [comment:7 nickm]:
> For CI purposes I've made a squashed and merged branch as
`nss_dh_squashed_merged`. PR at https://github.com/torproject/tor/pull/258
. It includes this branch, and both of the branches it is based on.
Thanks! Looks good so far. I've looked at all of the commits and nothing
sticks out as obviously wrong. I want to try to check the memory
management more closely in a few places if I can, though.
It looks like the `SSL_SignatureMaxCount()` prototype warning is still
there. (Probably needs a warning disabled in
src/lib/crypt_ops/crypto_nss_mgt.c.) Also the Rust build fails during
`make check` due to a duplication of
src/lib/crypt_ops/crypto_openssl_mgt.c in
`src_lib_libtor_crypt_ops_a_SOURCES`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26817#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs