[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27003 [Core Tor/Tor]: Regression: 'SETCONF ORPort' can kill tor process
#27003: Regression: 'SETCONF ORPort' can kill tor process
-----------------------------------------------+---------------------------
Reporter: atagar | Owner: nickm
Type: defect | Status:
| merge_ready
Priority: High | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor:
| unspecified
Severity: Normal | Resolution:
Keywords: regression, 035-must 034-backport | Actual Points:
Parent ID: | Points:
Reviewer: asn | Sponsor:
-----------------------------------------------+---------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
Hmm, I can't seem to be able to repro this bug neither with
`bug27003_034_v2^` or with `7e4ac02`. See logs in the end of this post.
In any case, I manually analyzed this patch with regards to the #25939
changes to make sure that it doesn't impact HSes. I think there is no
problem here for the following reason:
- If after a HUP we end up with HSes enabled, this change should not cause
issues since the periodic HS event will just trigger immediately after in
the event loop and do all the useful HS stuff.
- If after a HUP we end up with no HSes enabled, this patch does not
impact behavior since it only mods `periodic_event_enable()` and not
`period_event_disable()`.
Furthermore, chutney tests run well for me, so this seems like a good
thing to `merge_ready`.
----
Here are logs of a successful run with an unpatched `bug27003_034_v2^`:
{{{
$ ./src/or/tor -f ../confs/bug27003
Aug 07 11:48:01.860 [notice] Tor 0.3.4.4-rc-dev (git-861d690018c213ad)
running on Linux with Libevent 2.1.8-stable, OpenSSL 1.1.0h, Zlib 1.2.11,
Liblzma N/A, and Libzstd N/A.
Aug 07 11:48:01.860 [notice] Tor can't help you if you use it wrong! Learn
how to be safe at https://www.torproject.org/download/download#warning
Aug 07 11:48:01.860 [notice] Read configuration file
"/home/f/Computers/tor/mytor/../confs/bug27003".
Aug 07 11:48:01.863 [notice] Your ContactInfo config option is not set.
Please consider setting it, so we can contact you if your server is
misconfigured or something else goes wrong.
Aug 07 11:48:01.863 [notice] Based on detected system memory,
MaxMemInQueues is set to 5754 MB. You can override this by setting
MaxMemInQueues by hand.
Aug 07 11:48:01.863 [warn] ControlPort is open, but no authentication
method has been configured. This means that any program on your computer
can reconfigure your Tor. That's bad! You should upgrade your Tor
controller as soon as possible.
Aug 07 11:48:01.863 [notice] Scheduler type KIST has been enabled.
Aug 07 11:48:01.863 [notice] Opening Control listener on 127.0.0.1:9059
Aug 07 11:48:01.863 [notice] Opening OR listener on 0.0.0.0:0
Aug 07 11:48:01.863 [notice] OR listener listening on port 34639.
Aug 07 11:48:01.000 [notice] Configured to measure directory request
statistics, but no GeoIP database found. Please specify a GeoIP database
using the GeoIPFile option.
Aug 07 11:48:01.000 [notice] Your Tor server's identity key fingerprint is
'Unnamed F56258E818AEFB2BF55F5DDF8DD7D63DF0C0F63F'
Aug 07 11:48:01.000 [notice] Bootstrapped 0%: Starting
Aug 07 11:48:02.000 [warn] Please upgrade! This version of Tor (0.3.4.4
-rc-dev) is not recommended, according to the directory authorities.
Recommended versions are:
0.2.9.14,0.2.9.15,0.2.9.16,0.3.2.10,0.3.2.11,0.3.3.2-alpha,0.3.3.3-alpha,0.3.3.4-alpha,0.3.3.5-rc,0.3.3.6,0.3.3.7,0.3.3.8,0.3.3.9,0.3.4.1-alpha,0.3.4.2-alpha,0.3.4.3-alpha,0.3.4.4-rc,0.3.4.5-rc,0.3.4.6-rc
Aug 07 11:48:04.000 [notice] Starting with guard context "default"
Aug 07 11:48:04.000 [notice] Bootstrapped 80%: Connecting to the Tor
network
Aug 07 11:48:04.000 [notice] Bootstrapped 85%: Finishing handshake with
first hop
Aug 07 11:48:04.000 [notice] Guessed our IP address as XXX (source:
204.13.164.118).
Aug 07 11:48:05.000 [notice] Bootstrapped 90%: Establishing a Tor circuit
Aug 07 11:48:06.000 [notice] Tor has successfully opened a circuit. Looks
like client functionality is working.
Aug 07 11:48:06.000 [notice] Bootstrapped 100%: Done
Aug 07 11:48:06.000 [notice] Now checking whether ORPort XXX:34639 is
reachable... (this may take up to 20 minutes -- look for log messages
indicating success)
Aug 07 11:48:07.000 [notice] New control connection opened from 127.0.0.1.
Aug 07 11:48:11.000 [warn] ControlPort is open, but no authentication
method has been configured. This means that any program on your computer
can reconfigure your Tor. That's bad! You should upgrade your Tor
controller as soon as possible.
Aug 07 11:48:11.000 [notice] Closing no-longer-configured OR listener on
0.0.0.0:34639
Aug 07 11:48:11.000 [notice] Closing old OR listener on 0.0.0.0:34639
Aug 07 11:48:14.000 [notice] Your ContactInfo config option is not set.
Please consider setting it, so we can contact you if your server is
misconfigured or something else goes wrong.
Aug 07 11:48:14.000 [warn] ControlPort is open, but no authentication
method has been configured. This means that any program on your computer
can reconfigure your Tor. That's bad! You should upgrade your Tor
controller as soon as possible.
Aug 07 11:48:14.000 [notice] Opening OR listener on 0.0.0.0:9999
Aug 07 11:48:14.000 [notice] Heartbeat: It seems like we are not in the
cached consensus.
Aug 07 11:48:14.000 [notice] Heartbeat: Tor's uptime is 0:00 hours, with 6
circuits open. I've sent 15 kB and received 16 kB.
Aug 07 11:48:14.000 [notice] Circuit handshake stats since last time: 0/0
TAP, 0/0 NTor.
Aug 07 11:48:14.000 [notice] Since startup, we have initiated 0 v1
connections, 0 v2 connections, 0 v3 connections, and 1 v4 connections; and
received 0 v1 connections, 0 v2 connections, 0 v3 connections, and 0 v4
connections.
Aug 07 11:48:14.000 [notice] DoS mitigation since startup: 0 circuits
killed with too many cells. [cc not enabled] [conn not enabled] 0 single
hop clients refused.
Aug 07 11:48:14.000 [notice] Your Tor server's identity key fingerprint is
'Unnamed F56258E818AEFB2BF55F5DDF8DD7D63DF0C0F63F'
Aug 07 11:48:14.000 [notice] Now checking whether ORPort XXX:9999 is
reachable... (this may take up to 20 minutes -- look for log messages
indicating success)
Aug 07 11:48:14.000 [notice] Configured to measure directory request
statistics, but no GeoIP database found. Please specify a GeoIP database
using the GeoIPFile option.
^CAug 07 11:48:17.000 [notice] Interrupt: we have stopped accepting new
connections, and will shut down in 30 seconds. Interrupt again to exit
now.
}}}
{{{
$ ncat localhost 9059
AUTHENTICATE
250 OK
RESETCONF ORPort
250 OK
SETCONF ORPort=9999
250 OK
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27003#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs