[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt
#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--------------------------+--------------------------------
Reporter: chelseakomlo | Owner: teor
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust | Actual Points:
Parent ID: | Points:
Reviewer: teor | Sponsor:
--------------------------+--------------------------------
Comment (by teor):
Replying to [comment:3 teor]:
> Replying to [comment:2 cypherpunks3]:
> > But there's a bug upstream in rustfmt, which happens when it's
configured with max_width=80 (like it is in `src/rust/.rustfmt.toml`).
>
> I'm not sure about the impact of the bug.
> Does it produce ugly formatting, or is the syntax incorrect?
>
> Do you think we should give up on max_width=80?
> We can reconsider wrapping to 80 characters when stable supports
wrapping comments.
>
> If we want to match Tor's C files, we should be wrapping to 79
characters:
>
https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n177
I opened #27071 to deal with the max_width issue.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26972#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs