[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27068 [Core Tor/Chutney]: TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT
#27068: TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT
------------------------------+------------------------------------
Reporter: catalyst | Owner: (none)
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Chutney | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #27067 | Points:
Reviewer: | Sponsor:
------------------------------+------------------------------------
Changes (by teor):
* status: new => needs_review
Comment:
I fixed this issue by making test-network.sh use CHUTNEY_TOR and
CHUTNEY_TOR_GENCERT as binary paths if TOR_DIR is not a Tor build
directory, rather than just searching PATH for the standard binary names.
This change allows CHUTNEY_TOR to be set as a workaround to #27067, even
without the changes in #27067.
I also made the following changes:
* If CHUTNEY_TOR or CHUTNEY_TOR_GENCERT aren't binary paths, use them as
binary names to search PATH
* Tell the user how chutney is trying to find tor binaries
* Document chutney's binary search order better
I didn't swap the TOR_DIR and CHUTNEY_TOR search order, because (as far as
I understand) chutney is mainly used in Tor build directories. And a major
change like that could break compatibility with existing setups.
Please see the earlier commits in my branch bug27067 on
https://github.com/teor2345/chutney.git
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27068#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs