[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--------------------------------+------------------------------------
 Reporter:  chelseakomlo        |          Owner:  teor
     Type:  enhancement         |         Status:  needs_revision
 Priority:  Medium              |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor        |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  rust, 036-proposed  |  Actual Points:
Parent ID:  #24629              |         Points:
 Reviewer:  teor                |        Sponsor:
--------------------------------+------------------------------------
Changes (by teor):

 * keywords:  rust => rust, 036-proposed


Comment:

 Rust stable and beta disagree about some formatting. For example, see
 privcount_shamir's  #26973: https://travis-
 ci.org/teor2345/privcount_shamir/jobs/414426254#L1612

 We could merge this patch with the travis check disabled, because the rust
 code passes on rustfmt 0.99.1.

 Either way, we should defer the remaining tasks until Tor 0.3.6:
 * wait until rustfmt 0.99.1 hits stable
 * do a final format with rustfmt
 * activate the travis rustfmt check

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26972#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs