[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes
#26940: Privcount blinding and encryption: doc fixes
-------------------------------------------------+-------------------------
Reporter: teor | Owner: nickm
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: privcount, 035-roadmap-master, 035 | Actual Points:
-triaged-in-20180711, rust |
Parent ID: #25669 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: assigned => needs_review
Comment:
I've done this as the final part of my branch `ticket26939_26943_26940`;
PR at https://github.com/nmathewson/privcount_shamir/pull/3 .
While doing this I fixed a couple of extra bugs, one big, one small.
* big: it was possible to create a TR whose public key would give it an
X coordinate of zero. If you did that, then the TR's "share" would
actually be the un-split secret data. Good thing we caught this before
production!
* small: the Rand implementation for FE didn't use the from_u64_unbiased
method.
If you'd like even more doctests, I'd like to do that after merging this
branch, since it's already grown pretty large.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26940#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs