[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 I figured out how to get fix the bug, however, with a catch: instead of
 using `fascist_firewall_choose_address_base()` to choose the address in
 `fascist_firewall_choose_address_ls()`, I do it manually with:

 {{{
   if (have_v6 && (pref_ipv6 || !have_v4)) {
     tor_addr_copy(&ap->addr, &addr_v6);
     ap->port = port_v6;
   } else if (have_v4 && (!pref_ipv6 || !have_v6)) {
     tor_addr_copy(&ap->addr, &addr_v4);
     ap->port = port_v4;
   }
 }}}

 Would this be okay?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs