[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()
#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: prop224, tor-hs, single-onion, | Actual Points:
ipv6, 034-triage-20180328, |
034-removed-20180328 |
Parent ID: #23493 | Points: 1
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Comment (by neel):
Replying to [comment:31 teor]:
> Replying to [comment:30 teor]:
> > I think you might be expecting fascist_firewall_choose_address_base()
to always return a valid address. But sometimes, there won't be any
reachable addresses. If there aren't any reachable addresses, we need the
3-hop fallback code, which hasn't been written yet.
>
> You can log a BUG() warning and fail the connection when there's no
reachable address. We can write the 3-hop fallback code later in #23818.
I plan to do this after have reverted my address choosing code and
switched back to `fascist_firewall_choose_address_base()`.
I do have a question: where should I put the `BUG()` warning when there's
no reachable address?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs