[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26456 [Applications/Tor Browser]: HTTP .onion sites inherit previous page's certificate information

#26456: HTTP .onion sites inherit previous page's certificate information
---------------------------------------------+-----------------------------
 Reporter:  pospeselr                        |          Owner:  pospeselr
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Very High                        |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by arthuredelstein):

 I am unsure what the comment
 {{{
  // Ignore GetSSLStatus result
 }}}
 means. It seems like you are saving the result of GetSSLStatus, not
 ignoring it.

 This line:
 {{{
 mSSLStatus = nullptr;
 }}}
 could be moved inside the if block above it.

 Otherwise the code looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26456#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs