[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24056 [Applications/Tor Browser]: UI locale is detectable by button width
#24056: UI locale is detectable by button width
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Major | Resolution:
Keywords: tbb-fingerprinting, | Actual Points:
TorBrowserTeam201808R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:6 arthuredelstein]:
> Here's the revised patch:
> https://github.com/arthuredelstein/tor-browser/commit/24056+1
It seems we don't need to potentially adjust `aFile` in
{{{
nsresult nsContentUtils::FormatLocalizedString(
PropertiesFile aFile,
const char* aKey,
const nsTArray<nsString>&
aParamArray,
nsAString& aResult)
}}}
as it does not get touched in it but rather gets passed on.
I guess we are safe regarding `GetLocalizedEllipsis()`? At least I hope
so, assuming the localization folks adhered to Mozilla's advice to use
`\u2026` for it...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24056#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs