[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26779 [Core Tor/Tor]: atomic_init() and friends failing on clang

#26779: atomic_init() and friends failing on clang
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  jenkins, regression, 032-backport,   |  Actual Points:
  033-backport, 034-backport, 035-must           |
Parent ID:                                       |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 Ok this seems plausible to me that it detects a working stdatomic, and if
 not, falls back to our previous mutex-based functions.

 I'm setting this to merge ready, but with the caveat that I'm not the best
 person to review this to ensure that all the stdatomic stuff is sane. But
 the ifdef changes check out. The 033 branch does appear to replace all
 usage of HAVE_STDATOMIC_H with HAVE_WORKING_STDATOMIC.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26779#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs