[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26961 [Applications/Tor Browser]: implement new user onboarding

#26961: implement new user onboarding
--------------------------------------+--------------------------------
 Reporter:  mcs                       |          Owner:  mcs
     Type:  defect                    |         Status:  needs_revision
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201808      |  Actual Points:
Parent ID:  #25695                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201808R => TorBrowserTeam201808


Comment:

 Replying to [comment:9 mcs]:
 > We made a few small improvements and also incorporated the final
 onboarding artwork. Here are the commits to review:

 This works for me, nice! I was a bit puzzled, though, that the circuit
 display pane (and every pane after it) does not have a button leading to
 the next pane. Is that intentional?

 > One Torbutton patch:
 >
 ​https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug26961-01&id=4c69fedc9a0a927aea5d29e5060acb0df7016fef

 Looks good, but please rebase against `master` (note, there is no
 `observe()` imported anymore, we might want to do that again).

 > and two tor-browser patches:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug26961-02&id=e10e27a50893c473ed905a50715f35824185a87e

 Looks good to me.

 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug26961-02&id=b8dca4037d4dba3bbc27ee9989a09928446085f1

 Looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26961#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs