[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26884 [Applications/Tor Browser]: Update preferences.xul to make it work on mobile

#26884: Update preferences.xul to make it work on mobile
-------------------------------------------------+-------------------------
 Reporter:  igt0                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton,                       |  Actual Points:
  TorBrowserTeam201808R                          |
Parent ID:  #26531                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:9 sysrqb]:
 > Replying to [comment:3 igt0]:
 > > XUL doesn't work well on mobile, so I implemented the mobile
 preferences in XHTML.
 > >
 > > Initially, I tried to make the code reusable across the mobile and
 desktop, however I was losing lot of time trying to make the Desktop
 version work. So this patchset has just the **mobile** implementation.
 > >
 >
 > The original XUL implementation still works on Desktop, correct? Only
 mobile uses XHTML?
 >
 > > You can see the patches here:
 > > https://github.com/igortoliveira/torbutton/commits/26884
 > >
 > > **Bug 26884 - Part 1: Move show_torbrowser_manual and
 get_general_useragent_locale to utils**
 > >
 https://github.com/igortoliveira/torbutton/commit/07382c5ee23470bbc08a785c2b349fdb06010696
 > >
 >
 > Seems okay - but **Arthur**, maybe you want to skim through one?

 I have some nits:
 a) Please keep the comment which was available above
 `torbutton_show_torbrowser_manual()`.
 b)
 {{{
 // torbutton_show_torbrowser_manual() returns true.
 }}}
 needs to get reworded.
 c) If there is an error in `get_general_useragent_locale()` we should have
 some way of showing it (e.g. by emitting a message to the console), even
 if the usual logging functionality is not available in the module. I'd
 like to avoid omitting any kind of notification in such a case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26884#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs