[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface



#27180: Remove DetailsDocumentFields interface
-----------------------------+------------------------------
 Reporter:  irl              |          Owner:  irl
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 I think it's okay to just remove it.

 In fact, regarding `OrderParameters`, I think that these shouldn't use
 `DetailsDocumentFields` anyway, because parameter values and document
 fields are not necessarily the same thing. They happen to be the same in
 this case, and in most cases that makes sense, but there might be cases
 where they are not.

 Should I merge this change then?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27180#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs