Re: [tor-bugs] #27157 [Webpages/Website]: Update Tor FAQ - Tor has directory guards

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27157: Update Tor FAQ - Tor has directory guards
------------------------------+-----------------------------
 Reporter:  teor              |          Owner:  (none)
     Type:  defect            |         Status:  merge_ready
 Priority:  Medium            |      Milestone:
Component:  Webpages/Website  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  easy doc, FAQ     |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:  hiro              |        Sponsor:
------------------------------+-----------------------------

Comment (by irl):

 traumschule: I can't speak for hiro but I know that I prefer to review
 small changes. If you pile up a whole load of commits in one PR then I
 would probably ignore it until it's too old to consider rebasing it and
 then it would never be merged. Small PRs are easy to review and improve
 your chances that it is merged.

 There are also quite a few people (I count 13 people) that can review and
 merge website changes, not just hiro. By setting the reviewer you will
 cause others that might have looked at your changes to ignore them until
 hiro is able to look at them. The reviewer field should really only be set
 by the person that is taking the review, or if you've already discussed
 with them the specific ticket.

 If all the changes you're making are in the same file (like the FAQ) then
 you could put all these together in the same PR especially if they are
 each only small changes in that file. As soon as you start touching
 unrelated things this should always be in a separate branch. Even so, I
 could see that your first change could already be merged while you're
 still working on other changes. There is no reason to artificially cause
 delays here.

 FWIW,
 [[https://github.com/torproject/webwml/pull/13/commits/e2e7bc662a5c6e584a3b379964156aac8f4fad25|commit
 e2e7bc6]] looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27157#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs