[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26884 [Applications/Tor Browser]: Update preferences.xul to make it work on mobile



#26884: Update preferences.xul to make it work on mobile
-------------------------------------------------+-------------------------
 Reporter:  igt0                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201808  |  Actual Points:
Parent ID:  #26531                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 Updated code:

 **Bug 26884 - Part 1: Move show_torbrowser_manual and
 get_general_useragent_locale to utils**
 https://github.com/igortoliveira/torbutton/commit/17aae7176531a7fa5617b31a6c6dd22168f689fb

 **Bug 26884 - Part 2: Create mobile security slider**
 https://github.com/igortoliveira/torbutton/commit/2bf6712165fde40317556eefbd9c33d223f9a010

 **Bug 26884 - Part 3: Remove optionsURL from install.rdf**
 https://github.com/igortoliveira/torbutton/commit/b88b7493c6831697c7214ef6de93addf48237b03

 Replying to [comment:20 gk]:
 > Looks good, one final nit: could you remove the comma in `torOn:
 torbutton_tor_check_ok(),`? We only have one item in the object.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26884#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs