Re: [tor-bugs] #27232 [Applications/Tor Browser]: Updater redowloads and reinstalls update again

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27232: Updater redowloads and reinstalls update again
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  ff60-esr                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 I think this is because the update URL is formatted here:
 {{{
   async formatUpdateURL(url) {
     const locale = await this.getLocale();

     return url.replace(/%(\w+)%/g, (match, name) => {
       switch (name) {
         case "PRODUCT":
           return Services.appinfo.name;
         case "VERSION":
 #ifdef TOR_BROWSER_UPDATE
           return TOR_BROWSER_VERSION;
 #else
           return Services.appinfo.version;
 #endif
 }}}

 `app.update.url` is:
 `https://aus1.torproject.org/torbrowser/update_3/%CHANNEL%/%BUILD_TARGET%/%VERSION%/%LOCALE%`

 Looking at the update url:
 https://aus1.torproject.org/torbrowser/update_3/alpha/Linux_x86_64-gcc3/8.0a9
 /en-US

 `%VERSION%` is compile-time hard-coded as the original version number. I
 think we want the `torbrowser.version` pref?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27232#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs