[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27232 [Applications/Tor Browser]: Updater redowloads and reinstalls update again
#27232: Updater redowloads and reinstalls update again
--------------------------------------+--------------------------
Reporter: sysrqb | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff60-esr | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------
Comment (by sysrqb):
Replying to [comment:2 mcs]:
> Replying to [comment:1 sysrqb]:
> > ...
> > `%VERSION%` is compile-time hard-coded as the original version number.
I think we want the `torbrowser.version` pref?
>
> The torbrowser.version value should be the same as the compile time
define TOR_BROWSER_VERSION. We had to define TOR_BROWSER_VERSION because
there are some places in the update code where we cannot access the prefs
(at least that is what I remember). In any case, after the browser is
updated to 8.0a10, %VERSION% should be formatted using the new version
number. Or am I missing something?
>
Nope, that sure does make sense.
> This is a dumb question, but are you sure the update succeeded? With one
of my copies of 8.0a9 on macOS, the update does not want to apply. I am
not yet sure why not though.
After restarting, torbrowser.version is set a 8.0a10, and I also have the
new `about:tor` (and onboarding), so the update did apply. So I'm not sure
what's going on here.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27232#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs