[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23576 [Core Tor/Tor]: Make service_intro_point_new() take a node instead of an extend_info

#23576: Make service_intro_point_new() take a node instead of an extend_info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328, fast-fix                 |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.6.x-final


Comment:

 Replying to [comment:13 asn]:
 > This looks good and I like the code simplification!
 >
 > I left a few nitpicks on the PR that you might want to handle.

 See the PR for my changes.

 > Also, should we try to rebase this so that we can see the appveyor green
 checkmark (now that #26986 got fixed)?

 See my branch bug23576-rebased:
 * https://github.com/teor2345/tor/tree/bug23576-rebased
 * https://ci.appveyor.com/project/teor2345/tor/build/1.0.84
 * https://travis-ci.org/teor2345/tor/builds/419564854

 I'd like to defer the merge to early in 0.3.6, for the same reasons as:
 https://trac.torproject.org/projects/tor/ticket/23588#comment:52

 We're still missing #23818, and when we test in #27251, we might find
 we're missing other things as well. I'd like to have a full release to
 implement and test them.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23576#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs