[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27268 [Applications/Tor Browser]: preferences cleanup
#27268: preferences cleanup
---------------------------------------------+-----------------------------
Reporter: rzb | Owner: tbb-team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff60-esr, TorBrowserTeam201808R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------------------+-----------------------------
Changes (by arthuredelstein):
* keywords: ff60-esr => ff60-esr, TorBrowserTeam201808R
* status: new => needs_review
Comment:
Replying to [ticket:27268 rzb]:
Thank you for finding these, rzb!
Here is my patch for review: https://github.com/arthuredelstein/tor-
browser/commit/27268
> pref("plugins.hide_infobar_for_missing_plugin", true);
> - dead pref? hxxps://dxr.mozilla.org/mozilla-
esr60/search?q=hide_infobar_for_missing_plugin -> 0 results found
>
> pref("plugins.hideMissingPluginsNotification", true);
> - dead pref? hxxps://dxr.mozilla.org/mozilla-
esr60/search?q=hideMissingPluginsNotification -> 0 results found
Yes, I confirmed that "plugins.hideMissingPluginsNotification" and
"plugins.notifyMissingFlash" were removed in https://bugzil.la/836415. And
"plugins.hide_infobar_for_missing_plugin" was migrated to
"plugins.hide_infobar_for_blocked_plugin" in https://bugzil.la/870112 and
then removed in https://bugzil.la/1027049
The plugin finder service was removed, so these notifications no longer
happen.
> pref("plugin.expose_full_path", false);
> - dead pref? hxxps://dxr.mozilla.org/mozilla-
esr60/search?q=expose_full_path -> 0 results found
Removed in https://bugzil.la/883671
The code now uses the "false" behavior always. (It never exposes a full
path.)
> unless you have custom code that re-implements this I don't think the
pref does anything anymore:
> pref("dom.mozTCPSocket.enabled", false);
> - hxxps://dxr.mozilla.org/mozilla-esr60/search?q=mozTCPSocket
Yes, this pref was removed in https://bugzil.la/1286530. I confirmed that
navigator.mozTCPSocket is only exposed in chrome contexts.
> pref("browser.usedOnWindows10", true);
> - dead pref? hxxps://hg.mozilla.org/mozilla-central/rev/5dd17564f294 ->
also uplifted to FF50
> - hxxps://dxr.mozilla.org/mozilla-esr60/search?q=usedOnWindows10 -> 2
remnants for .introURL but nothing for "browser.usedOnWindows10"
Yes, this was removed in https://bugzil.la/1274633
> pref("browser.selfsupport.enabled", false);
> pref("browser.selfsupport.url", "");
> - both removed in FF55 -> https://bugzilla.mozilla.org/1361578
> - hxxps://dxr.mozilla.org/mozilla-esr60/search?q=browser.selfsupport ->
0 results
> - hxxps://dxr.mozilla.org/mozilla-esr60/search?q=selfsupport -> 8
results but nothing that looks related to these 2 prefs
Confirmed.
> pref("browser.newtabpage.directory.ping", "data:text/plain,");
> - dead pref? removed in FF55: https://bugzilla.mozilla.org/1241390
Confirmed.
> pref("browser.newtabpage.directory.source", "data:text/plain,");
> pref("browser.newtabpage.enhanced", false);
> pref("browser.newtabpage.introShown", true);
> - all 3 were removed in FF60:
https://bugzilla.mozilla.org/buglist.cgi?bug_id=1370930,1433133
Confirmed.
> pref("browser.newtabpage.remote", false);
> - last remnants removed in FF60 (https://bugzilla.mozilla.org/1355166)
Confirmed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27268#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs