Re: [tor-bugs] #27319 [Core Tor/Tor]: remove buf_get_oldest_chunk_timestamp()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27319: remove buf_get_oldest_chunk_timestamp()
-------------------------------------+----------------------------------
 Reporter:  cypherpunks3             |          Owner:  (none)
     Type:  defect                   |         Status:  new
 Priority:  Medium                   |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  datatypes, buffers, oom  |  Actual Points:
Parent ID:  #23878                   |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+----------------------------------

Comment (by cypherpunks3):

 The sole consumer of this timestamp is `circuits_handle_oom()`, which uses
 it to sort a list to prioritize which circuits and connections to close
 first. (The `circuit_t` struct field `.age_tmp` also only exists for the
 OOM handler's benefit.)

 The sole place where this timestamp being produced matters (for the OOM
 handler) is in `mainloop/connection.c`, when writing to `conn->outbuf` in
 `connection_write_to_buf_impl_()`.

 All other users of `buf_t` have no interest in creating or reading this
 timestamp. Should it be replaced with `connection_t`-specific code, or
 removed entirely with no replacement?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27319#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs