[tor-bugs] #27332 [Core Tor/Tor]: outdated documentation for connection_handle_write_impl()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27332: outdated documentation for connection_handle_write_impl()
------------------------------+--------------------
     Reporter:  cyberpunks    |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  doc
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 {{{
  * This function gets called either from conn_write_callback() in main.c
  * when libevent tells us that conn wants to write, or below
  * from connection_buf_add() when an entire TLS record is ready.
 }}}

 '', or below ... when an entire TLS record is ready'' hasn't been accurate
 since
 [https://gitweb.torproject.org/tor.git/commit/?id=d9746bd468f551d1ada57d962b20eddd15256ce9
 d9746bd468f551d1ada57d962b20eddd15256ce9].

 It and connection_handle_read_impl also don't mention only ever being
 called indirectly via `connection_handle_write()`/read since
 [https://gitweb.torproject.org/tor.git/commit/?id=d3be00e0f454998db6387c8547d218a0db93db21
 d3be00e0f454998db6387c8547d218a0db93db21], but that's more readily
 apparent at least.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27332>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs