Re: [tor-bugs] #27224 [Core Tor/Tor]: Call node_get_all_orports() less from node_is_a_configured_bridge()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27224: Call node_get_all_orports() less from node_is_a_configured_bridge()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #26630                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by cyberpunks):

 Replying to [comment:4 teor]:
 > But it's slightly more correct to do:
 > {{{
 >   tor_addr_t node_ipv4;
 >   tor_addr_make_unspec(&node_ipv4, AF_INET);
 > }}}

 Could also just move the declaration inside the if statement, right before
 the `tor_addr_from_ipv4h()` call, right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27224#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs