[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27199 [Core Tor/Tor]: panic inside rust extern "C" function is undefined behavior

#27199: panic inside rust extern "C" function is undefined behavior
----------------------------------------------+----------------------------
 Reporter:  cyberpunks                        |          Owner:  (none)
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.5.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by chelseakomlo):

 This change looks ok to me (I can't think of a use case when we would want
 to allow for unwinding as opposed to aborting).

 Did you manually test this change with the different builds (test, bench,
 etc) to ensure that the project still builds successfully?

 I would also like to make sure this passes Jenkins correctly (we don't
 seem to have Travis set up so I'll wait for other network team members to
 weigh in on how to see the status of the build).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27199#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs