[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21787 [Applications/Tor Browser]: Make sure exposing the calendar information does not leak the locale
#21787: Make sure exposing the calendar information does not leak the locale
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-fingerprinting, ff60-esr | Actual Points:
TorBrowserTeam201808R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by arthuredelstein):
Replying to [comment:13 mcs]:
> r=brade, r=mcs
> This looks good to us and some quick testing shows that it works (at
least for some examples on https://developer.mozilla.org/en-
US/docs/Web/HTML/Element/input/date).
>
> At first I was worried that some occurrences of `mSpoofEnglish` were
missing `this.` in front of them, but I think the global JS object is
`this` in those places so the code is OK.
Thanks, good catch. I think it's better to make the `this` explicit. So I
made a new version that uses `this.mSpoofEnglish` everywhere:
https://github.com/arthuredelstein/tor-browser/commit/21787+2
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21787#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs