[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27206 [Core Tor/Tor]: rust protover_all_supported() takes forever on some inputs

#27206: rust protover_all_supported() takes forever on some inputs
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, protover, 033-backport,        |  Actual Points:
  034-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cyberpunks):

 Replying to [comment:4 chelseakomlo]:
 > Can you give more info about the reasoning for the test case changes

 The old version of the tests didn't hit enough codepaths, since the
 protocol name was entirely unknown it would bail out early and never reach
 the part where it had to call .retain(). So now they test that it doesn't
 hang nearly forever.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27206#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs