[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27373 [Core Tor/Tor]: add UTF-8 validation code
#27373: add UTF-8 validation code
---------------------------------+------------------------------------
Reporter: cyberpunks | Owner: (none)
Type: task | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.6.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust-wants, prop285 | Actual Points:
Parent ID: #24033 | Points:
Reviewer: | Sponsor:
---------------------------------+------------------------------------
Comment (by teor):
Replying to [comment:4 cyberpunks]:
> Replying to [comment:3 teor]:
>
> Fixed the tests and check-spaces, sorry bout that.
Thanks!
Can you also check that Surrogate code points fail to validate?
I couldn't see any in there.
(I'd like to be able to use these tests to make sure that our C and Rust
implementations match, so we should check all the code point types.)
> This is just a helper function and it hasn't been used anywhere yet, so
it has no impact on Tor for users on its own, does that still need a
changes file?
That's an interesting question!
We usually commit helper functions and the code the uses them in the same
branch, with a single changes file.
Adding a helper function and a unit test could potentially trigger
compilation warnings or unit test failures on some platforms.
So I think this change fits at least one of these criteria:
Anything that changes internals, documentation, or the build
system enough that somebody could notice. ….
Anything about which somebody might plausibly wonder "when
did that happen, and/or why did we do that" 6 months down the line.
https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n144
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27373#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs