[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27367 [Core Tor/Tor]: Authorities and relays should reject non-UTF-8 in relay descriptors
#27367: Authorities and relays should reject non-UTF-8 in relay descriptors
-------------------------------------------------+-------------------------
Reporter: teor | Owner: (none)
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.6.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust-wants, prop285, | Actual Points:
034-triage-20180328, 034-removed-20180328 |
Parent ID: #24033 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: new => needs_review
* milestone: Tor: unspecified => Tor: 0.3.6.x-final
Comment:
I pushed your branch to https://github.com/teor2345/tor/branches to get
CI.
We usually create valid descriptors, votes, and consensuses using chutney:
https://gitweb.torproject.org/chutney.git
In this case, an unpatched tor will happily copy non-unicode characters
from ContactInfo into its descriptor, and sign that descriptor.
Here are some existing test descriptors and votes:
https://gitweb.torproject.org/tor.git/tree/src/test/test_descriptors.inc
And here is the function that parses those descriptors:
https://gitweb.torproject.org/tor.git/tree/src/test/test_helpers.c#n90
If we're going to test for invalid descriptors, then we should probably
put the test in test_dir.c.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27367#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs