[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31100 [Circumvention/Snowflake]: Firefox addon not reporting any users
#31100: Firefox addon not reporting any users
-------------------------------------------------+-------------------------
Reporter: cohosh | Owner: cohosh
Type: defect | Status:
| merge_ready
Priority: Very High | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Major | Resolution:
Keywords: snowflake-webextension anti- | Actual Points:
censorship-roadmap-august |
Parent ID: | Points: 2
Reviewer: dcf | Sponsor:
| Sponsor28
-------------------------------------------------+-------------------------
Comment (by cohosh):
Replying to [comment:23 dcf]:
> I had a look. I don't see any obvious problems, but I still feel I don't
fully understand the relation and meaning of `active` vis-à-vis `running`.
I'm thinking we'll be better off not trying to reuse `ProxyPairs`, but use
their presence in the list as an indicator of whether they are in use or
not -- or perhaps separate lists of "pending" and "active" pairs. But
what's in the bug31100 branch is good to merge now.
Yeah I agree with this, that it would be better to refactor the proxy-pair
usage a bit. This was kind of a quick hack to get the timeout working. We
need at least two states (that the proxypair responded with an answer to
the broker, and that a datachannel has actually been opened with the
client), so I'm not sure mere presence in the list is quite enough. I made
another ticket #31310 for making a more careful change to the proxy pair
functionality here.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31100#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs