[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #31336 [Core Tor/Tor]: Fix usage for add_c_file.py

#31336: Fix usage for add_c_file.py
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core     |    Version:  Tor: 0.4.1.2-alpha
  Tor/Tor                |   Keywords:  043-should, network-team-roadmap-
     Severity:  Normal   |  september
Actual Points:           |  Parent ID:  #29217
       Points:  0.1      |   Reviewer:
      Sponsor:           |
  Sponsor31-can          |
-------------------------+-------------------------------------------------
 add_c_file.py was added in commit 2f31c8146f in 0.4.1.2-alpha.

 But it has a bug: the suggested usage fails with:
 {{{
 $ scripts/maint/add_c_file.py ./src/feature/dirauth/ocelot.c
 Made files successfully but couldn't identify include.am for
 ./src/feature/dirauth/ocelot.c
 Exit 1
 }}}

 The correct usage has no "./":
 {{{
 $ scripts/maint/add_c_file.py src/feature/dirauth/ocelot.c
 }}}

 We should fix the usage, or make topdir_file() use python's canonical path
 functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31336>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs