Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-must-nightly,                |  Actual Points:
  TorBrowserTeam201908                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:24 gk]:
 > > True, did it. But I realized that now `onPageHide` does nothing, which
 seems wrong. Can we also remove it? I'm not sure if the new patch changes
 some behaviour here, since I guess before onpagehide would stop updating
 the document?
 >
 > That's probably a question for mcs and brade and/or trying things out. I
 don't know the answer with a bunch of further investigations.

 Kathy and I think that onPageHide() can be removed since its purpose was
 to remove the listeners that presumably are now removed for us via the
 `LEGACY_ACTORS` mechanism. We only need a "one time" update at page load
 time. But it would be good to test things by loading about:tbupdate and
 making sure the version and release date are filled in.

 > 2a324a0e0db60fc42d714d73657833d3cdf438cc - okay (mcs/brade second look;
 are we good with the "second call earlier"-part?)

 This looks good to us. We tested the "access denied" case on macOS and saw
 an error alert as expected. We also tried to test the "read only file"
 system case but we did not seen an alert. I made a note to test that
 scenario again when Kathy and I are in a better position to debug it (we
 are in the middle of rebasing updater patches at the moment). I think we
 should use this patch for now and fix it up later if necessary,

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs