[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31356 [Core Tor/Tor]: 0.4.1 relays should list Padding=1, 2
#31356: 0.4.1 relays should list Padding=1,2
---------------------------------+------------------------------------
Reporter: mikeperry | Owner: (none)
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor | Version: Tor: 0.4.0.5
Severity: Normal | Resolution:
Keywords: wtf-pad, 041-should | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor: Sponsor2
---------------------------------+------------------------------------
Changes (by mikeperry):
* status: needs_revision => needs_review
Comment:
I think we should keep this simple, so that it can get in before
0.4.1-stable, with low risk. We do not support alphas once the stable is
released. This means that we can just bump the protover without doing all
of the extra effort to phase out Padding=1 in stages.
In other words: if this gets merged before 0.4.1-stable, then once
0.4.1-stable is released, it won't matter that our older 0.4.1 alpha
clients won't negotiate with newer 0.4.1 relays -- they are unsupported.
Similarly, it doesn't matter if 0.4.1-stable clients won't negotiate with
0.4.1-alpha relays -- those relays are also unsupported.
Here is a cleanly organized PR against 0.4.1 that passes CI and is now
actually ready for review: https://github.com/torproject/tor/pull/1230
FTR: I didn't call you crazy. I called this entire situation crazy (which
I meant to include my response). I meant "crazy" in the sense that what we
were doing did not make sense to me and made things confusing to others.
The thing that upset me was that I am capable of viewing the CI logs of
PRs that I'm still actively rebasing and re-organizing.. I didn't need
those logs to occupy space in this ticket, and I didn't want them to,
which is why I didn't ask anyone to review it or even mention the branch
yet.. That said, I should have reacted more reasonably myself rather than
mirroring and exaggerating what I felt were unreasonable actions, which is
a bad habit of mine that I have been trying to break. It was the end of a
long week.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31356#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs